Fix reference counting in DispatchSemaphoreGuard::release#801
Merged
madsmtm merged 1 commit intomadsmtm:mainfrom Dec 4, 2025
Merged
Fix reference counting in DispatchSemaphoreGuard::release#801madsmtm merged 1 commit intomadsmtm:mainfrom
DispatchSemaphoreGuard::release#801madsmtm merged 1 commit intomadsmtm:mainfrom
Conversation
andyleiserson
force-pushed
the
semaphore
branch
from
678b5fd to
93cd5b0
Compare
Contributor
Author
|
The tests failed on GNUStep with a SEGV, I'm guessing what I did with |
madsmtm
added
bug
andyleiserson
force-pushed
the
semaphore
branch
2 times, most recently
from
cdf14ab to
18ed26c
Compare
madsmtm
reviewed
Nov 21, 2025
andyleiserson
force-pushed
the
semaphore
branch
from
18ed26c to
498543a
Compare
madsmtm
approved these changes
Dec 4, 2025
Owner
There was a problem hiding this comment.
Thanks!
This will be released in dispatch2 v0.4.0, which it'll likely take me a while to get to.
EDIT: I rebased to add a changelog entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ManuallyDropwas suppressing both the drop of the guard (as intended, to avoid double-signalling) and the drop of theDispatchRetained(not intended).